Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for var decl spans #4787

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

sophiajt
Copy link
Contributor

@sophiajt sophiajt commented Mar 9, 2022

Description

Remembers the var decl span in the variable's record. This helps us do better when getting the spans for an error make so we don't accidentally get the span of the closure.

fixes #4784 #4460

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@kubouch
Copy link
Contributor

kubouch commented Mar 9, 2022

I added #4460 to the fixed list. Seems like the same issue.

@sophiajt sophiajt merged commit 2ac9906 into nushell:main Mar 9, 2022
@sophiajt sophiajt deleted the var_decl_span branch March 9, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Span issue with error make
2 participants