Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest parsing #4765

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Fix rest parsing #4765

merged 2 commits into from
Mar 7, 2022

Conversation

sophiajt
Copy link
Contributor

@sophiajt sophiajt commented Mar 7, 2022

Description

This fixes an issue where a ...rest arg, if it has a specified type, overwrote the type of a previous argument in the signature.

Signatures of this form should now work:

def foo [
  --verbose(-v): bool, # my test flag
  ...rest: int # my rest comment
] {
  if $verbose {
    print "verbose!"
  } else {
    print "not verbose!" 
  }
}

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@sophiajt sophiajt merged commit a2723c2 into nushell:main Mar 7, 2022
@sophiajt sophiajt deleted the fix_rest_parsing branch March 7, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant