Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added real index column to history #4756

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

elferherrera
Copy link
Contributor

@elferherrera elferherrera commented Mar 6, 2022

Description

The index shown in the history column was the nushell row counter. This index changes when a filter was done on the table making it hard to use ! command
A new column that matches the real history index is introduced to make use of the ! reedline parsing. This index doesnt change when performing filtering on the table.

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@elferherrera elferherrera merged commit 7701c6b into nushell:main Mar 6, 2022
@elferherrera elferherrera deleted the history-menu-with-index branch March 8, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant