Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable to-nu to include the whole dfr if rows is not specified #4753

Merged
merged 1 commit into from
Mar 6, 2022
Merged

enable to-nu to include the whole dfr if rows is not specified #4753

merged 1 commit into from
Mar 6, 2022

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Mar 6, 2022

Description

Before this PR, to-nu would only return 5 rows if rows was not specified. This PR changes that to allow to-nu to return the entire dfr unless rows is specified.

closed #4752

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@fdncred fdncred merged commit 5ae5ef5 into nushell:main Mar 6, 2022
@fdncred fdncred deleted the to_nu_fix branch March 6, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get all rows from dfr to-nu
1 participant