Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow save to accept a list of strings #4743

Merged
merged 2 commits into from
Mar 5, 2022
Merged

Allow save to accept a list of strings #4743

merged 2 commits into from
Mar 5, 2022

Conversation

wingertge
Copy link
Contributor

Description

Save now accepts a list of strings and will treat it as a list of lines.

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@fdncred
Copy link
Collaborator

fdncred commented Mar 5, 2022

oops - there's a conflict now. I should've merged this one first I guess. sorry.

@wingertge
Copy link
Contributor Author

I think I merged it correctly, never done it before

@fdncred fdncred merged commit 4aa9a18 into nushell:main Mar 5, 2022
@fdncred
Copy link
Collaborator

fdncred commented Mar 5, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants