Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alias in docs/sample_config/config.toml #4669

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

lucatrv
Copy link
Contributor

@lucatrv lucatrv commented Feb 27, 2022

Description

Now la is alias for ls --all and ll is alias for ls --long.

Tests

Only documentation changes.

@sophiajt
Copy link
Contributor

Hi @lucatrv - thanks for the PR.

We're currently moving away from the config.toml style to a new config.nu style in the latest version of Nushell in main. We can make this change now, but it won't last very long as we'll soon replace the documentation to match the upcoming version of Nu.

@fdncred fdncred merged commit e3100e6 into nushell:main Feb 28, 2022
@lucatrv lucatrv deleted the patch-1 branch March 2, 2022 23:13
@lucatrv
Copy link
Contributor Author

lucatrv commented Mar 2, 2022

Hi @jntrnr and @fdncred,

Thank you for accepting my PR, I know it was a little thing but now I'm proud to be part of the Nushell community :)

Regarding the config.nu file, I understand it will be available with the next 0.60 release. I have a question related to it, because I'm interested in implementing (and maybe helping out if needed) the base16 color scheme in Nushell.

On one side, I found issue #1798, which was closed because staling, and the relative base16-nushell repository is still empty.

On the other side I found these instructions, which apply to config.nu.

So I wonder whether I should just wait for the 0.60 release and implement those instructions to config.nu, or otherwise if activities relative to issue #1798 are still to be completed. In case config.nu should be used, will the the base16-nushell repository be removed in future? However it would be a good thing for Nushell to be listed on https://github.com/chriskempson/base16.

By the way, IMHO base16 is the best color scheme available nowadays, and I would suggest to consider it as the default one for Nushell.

Thanks

@fdncred
Copy link
Collaborator

fdncred commented Mar 2, 2022

@lucatrv you're welcome!

You should use the latest main branch 0.59 right now and modify the config.nu as it shows in https://github.com/nushell/nushell/blob/main/docs/How_To_Coloring_and_Theming.md#theming. I wrote that base16 theme and it probably needs to be fixed. :)

If we had a lot of files that needed to be used for nushell and base16, I could see using our currently empty base16 repo. But first, I'd just start playing around with the main branch and the theming documentation you mentioned.

@lucatrv
Copy link
Contributor Author

lucatrv commented Mar 3, 2022

OK @fdncred I'll look at that, so starting from release 0.60 (with config.nu) code implemented with PR #1873 is not needed anymore, correct? Will it be removed or can it have other uses?

@fdncred
Copy link
Collaborator

fdncred commented Mar 4, 2022

I think we should remove it.

@lucatrv
Copy link
Contributor Author

lucatrv commented Mar 5, 2022

OK clear, then in future we could set a base16 template repository for Nushell in base16-nushell, which leverages config.nu.

I have a last question: I'm looking at the base16 sample theme for config.nu, but it errors out at without_color: false. I could not find documentation for without_color, should I open an issue or PR to remove that line?

@fdncred
Copy link
Collaborator

fdncred commented Mar 5, 2022

ya, IIRC without_color was the original name for this features but has been changed to use_ansi_coloring. Feel free to PR to change that terminology.

@lucatrv
Copy link
Contributor Author

lucatrv commented Mar 5, 2022

OK I just did here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants