Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to building for size #3924

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

sophiajt
Copy link
Contributor

No description provided.

@sophiajt sophiajt merged commit 2b7390c into nushell:main Aug 16, 2021
@sophiajt sophiajt deleted the build_for_size branch August 16, 2021 20:45
@aminya
Copy link
Contributor

aminya commented Sep 2, 2021

@jntrnr I don't think it is a good idea to use z. z turns of the loop vectorization, which means no SIMD usage, which is a huge performance hit. You should at least use s if you want.

Turning on LTO, would probably also reduce the size.

I recommend that you build nu binary with all the optimizations, and instead build less used plugins and binaries for size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants