Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move most of the peculiar argument handling for external calls into the parser #13089

Merged
merged 21 commits into from
Jun 20, 2024
Merged

Move most of the peculiar argument handling for external calls into the parser #13089

merged 21 commits into from
Jun 20, 2024

Commits on Jun 6, 2024

  1. wip: fix run-external quoting, parsing for external call

    @devyn
    devyn committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    e39dcab View commit details
    Browse the repository at this point in the history

  2. more parser tests

    @devyn
    devyn committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    604478f View commit details
    Browse the repository at this point in the history

  3. ok working on tests, and getting them to pass

    @devyn
    devyn committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    624cada View commit details
    Browse the repository at this point in the history

  4. more tests, and more fixes for tests

    @devyn
    devyn committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fdaf393 View commit details
    Browse the repository at this point in the history

  5. clippy fixes

    @devyn
    devyn committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8aaeb4a View commit details
    Browse the repository at this point in the history

  6. fix flattening for glob exprs in external args

    @devyn
    devyn committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    eb9dc93 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. try to make windows compile again

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    ebfd477 View commit details
    Browse the repository at this point in the history

  2. try to make windows compile again

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    f829994 View commit details
    Browse the repository at this point in the history

  3. fix clippy

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    67edc9b View commit details
    Browse the repository at this point in the history

  4. make it unnecessary to check expression type in run_external

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    9cc30bb View commit details
    Browse the repository at this point in the history

  5. clean up the handling of name in run_external, now that we don't need… 

    … to know about the expr
    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    7f17a13 View commit details
    Browse the repository at this point in the history

  6. clippy fixes

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    279a842 View commit details
    Browse the repository at this point in the history

  7. windows fix?

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d158b75 View commit details
    Browse the repository at this point in the history

  8. windows fix?

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    6bf0010 View commit details
    Browse the repository at this point in the history

  9. windows fix?

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    307b019 View commit details
    Browse the repository at this point in the history

  10. fix one of the run_external tests for windows

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    70a83e1 View commit details
    Browse the repository at this point in the history

  11. clean up the tests

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    e464b4e View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into fix-run-external-quoting

    @devyn
    devyn committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    8dcbe1d View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Merge branch 'main' into fix-run-external-quoting

    @devyn
    devyn committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    640889e View commit details
    Browse the repository at this point in the history

  2. remove quoted from StringInterpolation and add GlobInterpolation expr… 

    … instead
    @devyn
    devyn committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7f4f911 View commit details
    Browse the repository at this point in the history

  3. make embedded dollar quote interpolation work properly

    @devyn
    devyn committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    da83dcd View commit details
    Browse the repository at this point in the history