Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change escape function in parser #13022

Closed
wants to merge 1 commit into from
Closed

Change escape function in parser #13022

wants to merge 1 commit into from

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented May 31, 2024

Description

Attempts to fix #13016. Needs more testing, but it appears to fix the issue of running C:\Windows\System32\cmd.exe on Windows. It also doesn't break running ~/.config/bin/nu.

User-Facing Changes

Tests + Formatting

After Submitting

@devyn devyn mentioned this pull request Jun 1, 2024
Merged
@kubouch kubouch closed this Jun 1, 2024
kubouch pushed a commit that referenced this pull request Jun 3, 2024
@devyn
Fix external command name parsing with backslashes, and add tests (#1…
b50903c 
…3027)

# Description

Fixes #13016 and adds tests for many variations of external call
parsing.

I just realized @kubouch took a crack at this too (#13022) so really
whichever is better, but I think the
tests are a good addition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nushell 0.94.1 breaks Windows path handling
1 participant
@kubouch