Add fs feature to nix dependency
#12702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this should land before the release. |
|
Yep, it has to otherwise the crate might not publish. This could also break the release script midway and require a patch bump like in 0.90.1. |
|
nice! good catch. |
maxim-uvarov
pushed a commit
to maxim-uvarov/nushell
that referenced
this pull request
May 1, 2024
# Description Caught a compilation error using `cargo hack` -- `nu-utils` will not compile without the `fs` feature enabled for `nix`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caught a compilation error using
cargo hack--nu-utilswill not compile without thefsfeature enabled fornix.