Fix missing local socket feature #12698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindSoilder
approved these changes
Apr 29, 2024
maxim-uvarov
pushed a commit
to maxim-uvarov/nushell
that referenced
this pull request
May 1, 2024
# Description So sorry to do this during the pre-release freeze, but my plugin crate split PR broke local socket mode, because `nu-plugin-protocol` didn't have the compile feature to advertise the `LocalSocket` protocol feature. This is a very simple, configuration-only bugfix that I think really needs to be merged before the release, or else local socket mode won't work at all. # Tests + Formatting There's an oversight in my testing that caused this to not be caught: the engine really did have the feature, but it just wasn't advertising it, so for `stress_internals` it was still able to use it successfully. Post-release I'll try to make sure this is properly handled somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So sorry to do this during the pre-release freeze, but my plugin crate split PR broke local socket mode, because
nu-plugin-protocoldidn't have the compile feature to advertise theLocalSocketprotocol feature.This is a very simple, configuration-only bugfix that I think really needs to be merged before the release, or else local socket mode won't work at all.
Tests + Formatting
There's an oversight in my testing that caused this to not be caught: the engine really did have the feature, but it just wasn't advertising it, so for
stress_internalsit was still able to use it successfully. Post-release I'll try to make sure this is properly handled somehow.