Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I thought about bringing
nu_plugin_msgpack
in, but that is MPL with a clause that prevents other licenses, so rather than adapt that code I decided to take a crack at just doing it straight fromrmp
toValue
without anyrmpv
in the middle. It seems like it's probably faster, though I can't say for sure how much with the plugin overhead.@IanManske I started on a
Read
implementation forRawStream
but just specialized tofrom msgpack
here, but I'm thinking after release maybe we can polish it up and make it a real one. It works!User-Facing Changes
New commands:
from msgpack
from msgpackz
to msgpack
to msgpackz
Tests + Formatting
Pretty thorough tests added for the format deserialization, with a roundtrip for serialization. Some example tests too for both
from msgpack
andto msgpack
.toolkit fmt
toolkit clippy
toolkit test
toolkit test stdlib
After Submitting