Remove deprecated flags on commandline
#12658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanManske
added
pr:breaking-change
sholderbach
added
the
removal-after-deprecation
sholderbach
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
atuin migrated to the subcommands with a version check already, so no breakage for that integration to be expected.
https://github.com/atuinsh/atuin/blob/fc5522f45ef0735fb3b492329f95770203d21a7f/crates/atuin/src/shell/atuin.nu#L33-L46
fdncred
pushed a commit
to nushell/nu_scripts
that referenced
this pull request
May 19, 2024
Fixes for changes introduced by nushell/nushell#12658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
commandlineflags and API that was deprecated in 0.91.0 with #11877.User-Facing Changes
Users need to migrate to the new
commandlinesubcommands introduced in 0.91.0.