Make exit code available in catch block
#12648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-uvarov
pushed a commit
to maxim-uvarov/nushell
that referenced
this pull request
May 1, 2024
# Description Bandaid fix for nushell#12643, where it is not possible to get the exit code of a failed external command while also having the external command inherit nushell's stdout and stderr. This changes `try` so that the exit code of external command is available in the `catch` block via the usual `$env.LAST_EXIT_CODE`. # Tests + Formatting Added one test. # After Submitting Rework I/O redirection and possibly exit codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bandaid fix for #12643, where it is not possible to get the exit code of a failed external command while also having the external command inherit nushell's stdout and stderr. This changes
tryso that the exit code of external command is available in thecatchblock via the usual$env.LAST_EXIT_CODE.Tests + Formatting
Added one test.
After Submitting
Rework I/O redirection and possibly exit codes.