Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nu-cmd-lang cleanup #12609

Merged
merged 10 commits into from
Apr 25, 2024
Merged

nu-cmd-lang cleanup #12609

merged 10 commits into from
Apr 25, 2024

Conversation

IanManske
Copy link
Member

@IanManske IanManske commented Apr 21, 2024

Description

This PR does miscellaneous cleanup in some of the commands from nu-cmd-lang.

User-Facing Changes

None.

After Submitting

Cleanup the other commands in nu-cmd-lang.

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gotten around to reivew the if changes and am not sure if the parser is really guaranteeing all the things you now assert in match.

For the other things my general seal of approval.

@IanManske
Copy link
Member Author

Ok, let's try this out!

@IanManske IanManske merged commit b6d765a into nushell:main Apr 25, 2024
15 checks passed
@hustcer hustcer added this to the v0.93.0 milestone Apr 26, 2024
@IanManske IanManske deleted the nu-cmd-lang-cleanup branch May 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants