Make drop notification timing for plugin custom values more consistent #12341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps plugin custom values that have requested drop notification around during the lifetime of a plugin call / stream by sending them to a channel that gets persisted during the lifetime of the call. Before this change, it was very likely that the drop notification would be sent before the plugin ever had a chance to handle the value it received. Tests have been added to make sure this works - see the `custom_values` plugin.
sholderbach
reviewed
Mar 31, 2024
|
I believe this is good to merge for the point release. The existing plugin tests are pretty extensive and this only affects one feature that's not really used by anyone except @ayax79 yet |
|
@hustcer I believe this should go out with 0.92.1 |
Never mind, as we don't have a milestone for 0.92.1, and it won't stop us from shipping a patch release. what's more, I think it should be included in the 0.93.0 release note. |
|
Ah, okay, makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This keeps plugin custom values that have requested drop notification around during the lifetime of a plugin call / stream by sending them to a channel that gets persisted during the lifetime of the call.
Before this change, it was very likely that the drop notification would be sent before the plugin ever had a chance to handle the value it received.
Tests have been added to make sure this works - see the
custom_valuesplugin.cc @ayax79
User-Facing Changes
This is basically just a bugfix, just a slightly big one.
However, I did add an
as_mut_any()function for custom values, to avoid having to clone them. This is a breaking change.Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlib