Fix the bug for "bytes remove --end" .

[SebastianIonel]

This PR should close #11426 .

Description

Describe the bug

When using the --end option of bytes remove, nushell panics if the provided bytes don't exist. This doesn't seem to affect bytes remove w/o flag or bytes remove --all.

User-Facing Changes

Nushell doesn`t panic anymore.

Tests + Formatting

Behavior before fixing the bug:

Behavior after fixing the bug:

[WindSoilder]

Hi, thanks for your contribution! It'd be good to add a test for such behavior.

I think you can add it to examples

[WindSoilder]

Would you please add a test for it?

[SebastianIonel]

I am sorry, but for the moment, I don't really know how to add a test.

[amtoine]

@SebastianIonel
you should be able to copy-paste one of the Example from

nushell/crates/nu-command/src/bytes/remove.rs

Lines 85 to 120 in 9522052

	fn examples(&self) -> Vec<Example> {
	vec![
	Example {
	description: "Remove contents",
	example: "0x[10 AA FF AA FF] | bytes remove 0x[10 AA]",
	result: Some(Value::test_binary (
	vec![0xFF, 0xAA, 0xFF],
	)),
	},
	Example {
	description: "Remove all occurrences of find binary in record field",
	example: "{ data: 0x[10 AA 10 BB 10] } | bytes remove --all 0x[10] data",
	result: Some(Value::test_record(record! {
	"data" => Value::test_binary(vec![0xAA, 0xBB])
	})),
	},
	Example {
	description: "Remove occurrences of find binary from end",
	example: "0x[10 AA 10 BB CC AA 10] | bytes remove --end 0x[10]",
	result: Some(Value::test_binary (
	vec![0x10, 0xAA, 0x10, 0xBB, 0xCC, 0xAA],
	)),
	},
	Example {
	description: "Remove all occurrences of find binary in table",
	example: "[[ColA ColB ColC]; [0x[11 12 13] 0x[14 15 16] 0x[17 18 19]]] | bytes remove 0x[11] ColA ColC",
	result: Some(Value::test_list (
	vec![Value::test_record(record! {
	"ColA" => Value::test_binary ( vec![0x12, 0x13],),
	"ColB" => Value::test_binary ( vec![0x14, 0x15, 0x16],),
	"ColC" => Value::test_binary ( vec![0x17, 0x18, 0x19],),
	})],
	)),
	},
	]
	}

[WindSoilder]

Yup, just need to add something like 0x[10 AA FF] | bytes remove --end 0x[BB]

[fdncred]

You could also just add the test @WindSoilder added before closing his PR that does the same thing. https://github.com/nushell/nushell/pull/11427/files

[WindSoilder]

Thanks! Looks good to me