Allow more types for input list
#11195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`input list` now allows all types by using `into_string`. Custom formatting logic for records was removed. Allow ranges as an input types. Also made the prompt check depend on option, so `input list ""` will have an empty prompt, while `input list` does not. Resolve nushell#11181
|
Nice! Ya, it's probably best to remove that custom formatting. This seems to work for me. |
|
The only issue I see is that this allows to pass closures and blocks to |
|
I mean, it's a little weird to have a closure there. If you could unravel the closure into what it is, that would be ok, but just having a useless <Closure 3162> seems not too good. I'm not quite sure what a block would look like. |
|
@fdncred I thought about it, but I don't think that's possible. In theory |
|
I won't hold this PR up for a change, but it's still weird to have closures like this. |
|
Thanks |
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
`input list` now allows all types by using `into_string`. Custom formatting logic for records was removed. Allow ranges as an input types. Also made the prompt check depend on option, so `input list ""` will have an empty prompt, while `input list` does not. Resolve nushell#11181
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
`input list` now allows all types by using `into_string`. Custom formatting logic for records was removed. Allow ranges as an input types. Also made the prompt check depend on option, so `input list ""` will have an empty prompt, while `input list` does not. Resolve nushell#11181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input listnow allows all types by usinginto_string.Custom formatting logic for records was removed.
Allow ranges as an input types.
Also made the prompt check depend on option, so
input list ""will have an empty prompt, whileinput listdoes not.Resolve #11181