When using redirection, if a command generates non-zero exit code, the script should stop running #11191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtoine
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
the changes look simple, the tests good and i was able to reproduce the new expected behaviour...
thanks again @WindSoilder for working on this 🙏
let's land that and have better redirection 👌
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
…e script should stop running (nushell#11191) # Description Fixes: nushell#11153 To make sure scripts stop from running on non-zero exit code, we need to invoke `might_consume_external_result` on `PipelineData::ExternalStream`, so it can tell nushell if this command exists with non-zero exit code. And this pr also adjusts some test cases. # User-Facing Changes ```nushell ^false out> /dev/null; print "ok" ``` After this pr, it shouldn't print ok. # Tests + Formatting Done
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
…e script should stop running (nushell#11191) # Description Fixes: nushell#11153 To make sure scripts stop from running on non-zero exit code, we need to invoke `might_consume_external_result` on `PipelineData::ExternalStream`, so it can tell nushell if this command exists with non-zero exit code. And this pr also adjusts some test cases. # User-Facing Changes ```nushell ^false out> /dev/null; print "ok" ``` After this pr, it shouldn't print ok. # Tests + Formatting Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #11153
To make sure scripts stop from running on non-zero exit code, we need to invoke
might_consume_external_resultonPipelineData::ExternalStream, so it can tell nushell if this command exists with non-zero exit code.And this pr also adjusts some test cases.
User-Facing Changes
After this pr, it shouldn't print ok.
Tests + Formatting
Done