Build nu-protocol docs with all features enabled
#11180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholderbach
approved these changes
Nov 29, 2023
sholderbach
added a commit
to sholderbach/reedline
that referenced
this pull request
Nov 29, 2023
Inspired by nushell/nushell#11180 Make sure you can see all available types/symbols on docs.rs (e.g. `SqliteBackedHistory`) In a second step we should take care of annotating feature gated stuff correctly
fdncred
pushed a commit
to nushell/reedline
that referenced
this pull request
Nov 29, 2023
Inspired by nushell/nushell#11180 Make sure you can see all available types/symbols on docs.rs (e.g. `SqliteBackedHistory`) In a second step we should take care of annotating feature gated stuff correctly
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
# Description Currently, `PluginSignature` does not appear on [`docs.rs`](https://docs.rs/nu-protocol/latest/nu_protocol/index.html), since it is behind the `plugin` feature which is not enabled by default. This PR adds [metadata](https://docs.rs/about/metadata) to the Cargo.toml to get `docs.rs` to build docs with all features enabled.
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description Currently, `PluginSignature` does not appear on [`docs.rs`](https://docs.rs/nu-protocol/latest/nu_protocol/index.html), since it is behind the `plugin` feature which is not enabled by default. This PR adds [metadata](https://docs.rs/about/metadata) to the Cargo.toml to get `docs.rs` to build docs with all features enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
PluginSignaturedoes not appear ondocs.rs, since it is behind thepluginfeature which is not enabled by default. This PR adds metadata to the Cargo.toml to getdocs.rsto build docs with all features enabled.