Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add echo_env_mixed testbin to reduce windows only tests #11172

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

WindSoilder
Copy link
Collaborator

Description

We have seen some test cases which requires to output message to both stdout and stderr, especially in redirection scenario.

This pr is going to introduce a new echo_env_mixed testbin, so we can have less tests which only runs on windows.

User-Facing Changes

NaN

Tests + Formatting

NaN

After Submitting

NaN

@fdncred
Copy link
Collaborator

fdncred commented Nov 28, 2023

Good idea. Thanks.

@fdncred fdncred merged commit 182b0ab into nushell:main Nov 28, 2023
19 checks passed
@WindSoilder WindSoilder deleted the tests_based_on_append branch November 28, 2023 14:38
hardfau1t pushed a commit to hardfau1t/nushell that referenced this pull request Dec 14, 2023
# Description
We have seen some test cases which requires to output message to both
stdout and stderr, especially in redirection scenario.

This pr is going to introduce a new echo_env_mixed testbin, so we can
have less tests which only runs on windows.

# User-Facing Changes
NaN

# Tests + Formatting
NaN

# After Submitting
NaN
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
# Description
We have seen some test cases which requires to output message to both
stdout and stderr, especially in redirection scenario.

This pr is going to introduce a new echo_env_mixed testbin, so we can
have less tests which only runs on windows.

# User-Facing Changes
NaN

# Tests + Formatting
NaN

# After Submitting
NaN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants