deprecate std testing
#11151
Merged
deprecate std testing
#11151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtoine
added
pr:release-note-mention
|
i've added a note to the deprecation warning to clearly state that Nupm isn't production-ready but that people can still try it if they feel comfortable with a changing and unstable API 👌 |
hardfau1t
pushed a commit
to hardfau1t/nushell
that referenced
this pull request
Dec 14, 2023
# Description this PR deprecates the `std testing` module in favor of Nupm. the plan is to simply hide the module to the user but still use it internally when running the tests so that - users don't start to use this module and rather focus on Nupm - devs don't have to install anything to run the tests locally, they can just use `toolkit test stdlib` for instance the deprecation message will be very similar to nushell#11097 > **Note** > to demonstrate that the removal of such a command from the exposed modules of `std` will be transparent and not require the user to install anything, i have it [prepared in a branch based on this PR](amtoine/nushell@deprecate-std-testing...amtoine:nushell:hide-std-testing) > running `toolkit test stdlib` will run the standard library tests without an issue and yet `use std testing` won't work 👌 # User-Facing Changes `std testing run-tests` will be removed in `0.90` # Tests + Formatting # After Submitting
Merged
kubouch
pushed a commit
that referenced
this pull request
Jan 25, 2024
follow-up to - #11151 > **Important** > land only between 0.89 and 0.90 # Description this PR hides the `std testing` module from the outside. - moves `nu-std/std/testing.nu` to `nu-std/testing.nu` - removes the module from the standard library list of modules to parse - fixes `toolkit.nu` and the CI # User-Facing Changes `std testing` won't be part of the standard library anymore. # Tests + Formatting # After Submitting
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
# Description this PR deprecates the `std testing` module in favor of Nupm. the plan is to simply hide the module to the user but still use it internally when running the tests so that - users don't start to use this module and rather focus on Nupm - devs don't have to install anything to run the tests locally, they can just use `toolkit test stdlib` for instance the deprecation message will be very similar to nushell#11097 > **Note** > to demonstrate that the removal of such a command from the exposed modules of `std` will be transparent and not require the user to install anything, i have it [prepared in a branch based on this PR](amtoine/nushell@deprecate-std-testing...amtoine:nushell:hide-std-testing) > running `toolkit test stdlib` will run the standard library tests without an issue and yet `use std testing` won't work 👌 # User-Facing Changes `std testing run-tests` will be removed in `0.90` # Tests + Formatting # After Submitting
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
follow-up to - nushell#11151 > **Important** > land only between 0.89 and 0.90 # Description this PR hides the `std testing` module from the outside. - moves `nu-std/std/testing.nu` to `nu-std/testing.nu` - removes the module from the standard library list of modules to parse - fixes `toolkit.nu` and the CI # User-Facing Changes `std testing` won't be part of the standard library anymore. # Tests + Formatting # After Submitting
Merged
fdncred
pushed a commit
that referenced
this pull request
May 13, 2024
# Description Updates the command listed in the PR template to test the standard library, following from #11151.
FilipAndersson245
pushed a commit
to FilipAndersson245/nushell
that referenced
this pull request
May 18, 2024
# Description Updates the command listed in the PR template to test the standard library, following from nushell#11151.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR deprecates the
std testingmodule in favor of Nupm.the plan is to simply hide the module to the user but still use it internally when running the tests so that
toolkit test stdlibfor instancethe deprecation message will be very similar to #11097
User-Facing Changes
std testing run-testswill be removed in0.90Tests + Formatting
After Submitting