Alias completions with external completers does not work anymore (after #8123)

[thomasgoulet]

Describe the bug

I use fish as a completer with the exact same setup as in the docs.

Before, in 0.76 I could alias k = kubectl and get automcompletion for the resource names from the fish completion file (kubectl completion fish)

In 0.77, this completion does not work anymore and I have to use the full command to get completion.

How to reproduce

1. alias k = kubectl
2. > k get pods <TAB>

(0. Have kubectl installed and external completion setup)

Expected behavior

Autocomplete as if I typed kubectl get pods.

Screenshots

(Not screenshotting expected behavior because I'm at work)

Configuration

key	value
version	0.77.0
branch	makepkg
commit_hash	fd09609
build_os	linux-x86_64
build_target	x86_64-unknown-linux-gnu
rust_version	rustc 1.68.0 (2c8cc3432 2023-03-06) (Arch Linux rust 1:1.68.0-1)
cargo_version	cargo 1.68.0
build_time	2023-03-15 09:27:56 +00:00
build_rust_channel	release
features	default, zip
installed_plugins

Additional context

No response

[sholderbach]

I think this is a subissue of the regression observed in #8471. So the changes to the aliases do not play nice with the completions yet.

[thomasgoulet]

I think this is a subissue of the regression observed in #8471. So the changes to the aliases do not play nice with the completions yet.

The issue you mentioned is within 0.76.1, so the new alias changes were not in place.

[bartlibert]

I also have this issue and I noticed that aliases get expanded wrongly when passed to the external completer.
For example, I have an alias alias gp = git push.
I noticed parameters that are passed to the completer in this case are gp push instead of git push.
So it seems the alias is expanded, but the first part is not replaced with the first part of the expanded alias.

I have the following (ugly) workaround in my config and this seems to work (for carapace):

let carapace_completer = {|spans|
    let has_alias = ($nu.scope.aliases | where name == $spans.0)
    let spans = (if not ($has_alias | is-empty) {
      # put the first word of the expanded alias first in the span
      $spans | skip 1 | prepend ($has_alias | get expansion | split words | get 0)
    } else { $spans })
    carapace $spans.0 nushell $spans | from json

[aserowy]

Heho,

any progress on this issue?

Kind regards
Alexander

[aserowy]

I also have this issue and I noticed that aliases get expanded wrongly when passed to the external completer. For example, I have an alias alias gp = git push. I noticed parameters that are passed to the completer in this case are gp push instead of git push. So it seems the alias is expanded, but the first part is not replaced with the first part of the expanded alias.

I have the following (ugly) workaround in my config and this seems to work (for carapace):

let carapace_completer = {|spans|
    let has_alias = ($nu.scope.aliases | where name == $spans.0)
    let spans = (if not ($has_alias | is-empty) {
      # put the first word of the expanded alias first in the span
      $spans | skip 1 | prepend ($has_alias | get expansion | split words | get 0)
    } else { $spans })
    carapace $spans.0 nushell $spans | from json

Heho,

fyi. This snippet is not working anymore. In the cookbook is a running workaround.

Regards
Alexander