-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
else
statement captures mut
able variables
#7384
Comments
sophiajt
added a commit
that referenced
this issue
Dec 7, 2022
# Description fixes #7384 This is a stop-gap fix until we remove type-directed parsing. With this, you can create a `OneOf` shape that can be one of a list of syntax shapes. This gives you a little more control than you get with `Any`, allowing you to add `Block` without breaking other parsing rules. # User-Facing Changes `else` block will no longer capture variables as it will now use a block instead of a closure. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
thanks a lot 😌 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
from this discussion on the discord server with @fdncred and @jntrnr, it appears
mut
able variables showcase a strange behaviour when used in the lastelse
statement in afor
loop 🤔How to reproduce
run the following script
Expected behavior
here i simply expect the script to print nothing to the shell 😋
however i get
Screenshots
No response
Configuration
Additional context
No response
The text was updated successfully, but these errors were encountered: