Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split list <delim> doesn't remove first list item if it equals <delim> #7278

Closed
freijon opened this issue Nov 29, 2022 · 0 comments · Fixed by #7355
Closed

split list <delim> doesn't remove first list item if it equals <delim> #7278

freijon opened this issue Nov 29, 2022 · 0 comments · Fixed by #7355
Labels
🐛 bug Something isn't working inconsistent-behavior Behavior between different commands or types inconsistent/unexpected
Milestone
v0.73.0

Comments

@freijon
Copy link

freijon commented Nov 29, 2022 •
edited
Loading

Describe the bug

If a list is splitted and the delimiter equals the first entry in the list, this first item doesn't get removed from the resulting lists. It is, however, removed if the delimiter is somewhere in between or at the end of the list.

How to reproduce

  1. Run [a, b, c, a, c, e, a] | split list a | table -e
  2. Notice that the first a is still present in resulting list 0, but not in list 1.
  3. Result: [[a, b, c] [c, e]]

Expected behavior

All instances of a should be removed and the result should look like this:
[[b, c] [c, e]]

Screenshots

No response

Configuration

version | transpose key value | to md --pretty

key value
version 0.71.0
branch
commit_hash
build_os linux-x86_64
build_target x86_64-unknown-linux-gnu
rust_version rustc 1.65.0-nightly (gentoo)
cargo_version cargo 1.65.0-nightly
pkg_version 0.71.0
build_time 2022-11-23 19:56:47 +01:00
build_rust_channel release
features database, dataframe, default, trash, which, zip
installed_plugins

Additional context

No response
@sholderbach sholderbach added 🐛 bug Something isn't working inconsistent-behavior Behavior between different commands or types inconsistent/unexpected labels Nov 29, 2022
@WindSoilder WindSoilder mentioned this issue Dec 5, 2022
Merged
fdncred pushed a commit that referenced this issue Dec 6, 2022
@WindSoilder
fix split list when separater is the first element of list (#7355)
4ecc807 
# Description

Fixes: #7278

# User-Facing Changes

_(List of all changes that impact the user experience here. This helps
us keep track of breaking changes.)_

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
@hustcer hustcer added this to the v0.73 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working inconsistent-behavior Behavior between different commands or types inconsistent/unexpected
Projects
None yet
Milestone
v0.73.0
Development

Successfully merging a pull request may close this issue.

fix split list when separater is the first element of list WindSoilder/nushell
3 participants
@hustcer @freijon @sholderbach