Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Link to Command Reference led to HTTP 404 #993

Merged
merged 3 commits into from
Jul 30, 2023

Conversation

LeoniePhiline
Copy link
Contributor

@LeoniePhiline LeoniePhiline commented Jul 29, 2023

Hi y'all!

Not sure if this is right. I just noticed that the "Command reference" link at the bottom of nu_fundamentals.md is broken.

I tried fixing it - see diff.

However, there seem to be more places, like in the table of contents. (Edit: table of contents now also fixed in this PR.)

See also these search results.

Apparently, in some language versions (japanese, brazilian portugese, german, chinese), /book/command_reference.md exists, while in the default (english) version it does not exist and seems to be placed in /commands/README.md now.

I am confused. :)

@hustcer hustcer merged commit de3d060 into nushell:main Jul 30, 2023
2 checks passed
@hustcer
Copy link
Collaborator

hustcer commented Jul 30, 2023

Good catch, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants