Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak overlay new tip #992

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Conversation

gregokent
Copy link
Contributor

In the tip for Overlays are Recordable the text shows how to create a scratch overlay to record changes into before showing a less verbose version using overlay new.

However the more verbose version also uses overlay new before it's introduced, which I presume is meant to be overlay use and this change updates it for the English and German translation. The Chinese translation appears to be what I believe to be the correct usage and the other translations don't seem to have that section yet and have been left alone.

In the tip for `Overlays are Recordable` the text shows how to create a scratch overlay to record changes into before showing a less verbose version using `overlay new`.

However the more verbose version also uses `overlay new` before it's introduced, which I presume is meant to be `overlay use`
@fdncred
Copy link
Collaborator

fdncred commented Jul 29, 2023

I'm not following. overlay new seems to be a valid command. are you saying overlay new doesn't work or just that it should be overlay use in these two places?

@gregokent
Copy link
Contributor Author

The latter. I'm just saying that in that one specific spot (in both languages) it should be overlay use as overlay new doesn't get introduced as a concept until just after the more verbose example.

@fdncred
Copy link
Collaborator

fdncred commented Jul 29, 2023

ok, thanks!

@fdncred fdncred merged commit 7010230 into nushell:main Jul 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants