Expand external completer docs #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very nice! thanks for coming back to this! |
|
hmmm, I don't see the chapter. You may need to add a link somewhere else in order to get it to show up. |
|
Oh no! I link to it from the external completions doc page but didn't even think about having to add a nav entry to it 馃槄 It's late in my TZ but I'll add it tomorrow in a new PR. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #959, this PR tries to better explain how external completers work, how to integrate them and do a showcase of a possible config that leverages some of the provided examples.
I took the liberty of creating a new cookbook page for the examples, as the size of them was getting out of hand. There are probably some things to improve about clarity, wording and the general structure, so let me know if there's anything that needs changing 馃榿
On an unrelated note, I found this issue. In the troubleshooting section of the cookbook I address how to fix it, so I might redirect them to it after merging 馃