Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppid to ps examples #864

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Add ppid to ps examples #864

merged 1 commit into from
Apr 26, 2023

Conversation

pingiun
Copy link
Contributor

@pingiun pingiun commented Apr 6, 2023

Note that this is unreleased. This PR should be blocked until nushell/nushell#8750 has landed in a release

@hustcer
Copy link
Collaborator

hustcer commented Apr 6, 2023

Thanks for the PR, commands/docs/ps.md need not be modified, as all docs in commands/docs folder were created by a script, they will be updated after next nushell release. You can update the examples fn in crates/nu-command/src/system/ps.rs to add more examples

@fdncred
Copy link
Collaborator

fdncred commented Apr 6, 2023

I think the examples are probably fine to leave here but the commands/docs/ps.md will get overwritten as hustcer has said.

fdncred pushed a commit to nushell/nushell that referenced this pull request Apr 6, 2023
# Description

Add an extra example for the `ps` command

# User-Facing Changes

Only adds this example:


![image](https://user-images.githubusercontent.com/1576660/230374829-dc957b89-0a76-451d-baba-5e4463b150c3.png)

# Tests + Formatting

N/A

# After Submitting

This is related to nushell/nushell.github.io#864

Co-authored-by: Jelle Besseling <[email protected]>
@hustcer
Copy link
Collaborator

hustcer commented Apr 10, 2023

Thanks, we will merge it after nu v0.79 been released

@hustcer hustcer added the wait-after-next-release The PR will be merged after next Nu release label Apr 10, 2023
@hustcer hustcer merged commit b895063 into nushell:main Apr 26, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait-after-next-release The PR will be merged after next Nu release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants