Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node+VuePress TLC #268

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Node+VuePress TLC #268

merged 3 commits into from
Mar 9, 2022

Conversation

rgwood
Copy link
Collaborator

@rgwood rgwood commented Mar 9, 2022

A few website updates:

  • Upgrade GitHub Actions to Node 16 (from 12). 16 is the latest LTS release and 12 will be unsupported soon.
  • Upgrade VuePress minor version
  • Install the VuePress back-to-top and medium-zoom plugins; they were previously causing build warnings because they were enabled but not installed.
  • Exclude the old Nu book from search results; it was making the search results a lot worse (so many duplicates!)

Testing Performed

Manual testing: clicked around the website, confirmed that the search works as expected in both English and German, confirmed that the VuePress plugins now work.

Details

The back-to-top and medium-zoom plugins were set up in config.js but not installed; previously the build was generating these warnings:

warning An error was encountered in plugin "@vuepress/plugin-back-to-top"
warning An error was encountered in plugin "@vuepress/plugin-medium-zoom"

Adding the --debug flag to vuepress dev or vuepress build was enough to confirm that it was unable to find those plugins entirely. I'm not a VuePress expert by any means, but I looked around GitHub and confirmed that they need to be installed in package.json.

@sophiajt
Copy link
Contributor

sophiajt commented Mar 9, 2022

thanks!

@sophiajt sophiajt merged commit e90186b into nushell:main Mar 9, 2022
ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
…ushell#268)

* add tmp script

* fix more scripts

* remove tmp file

* migrate to new variable definition

* rename builtin variable back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants