Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intro for latest Nu version #264

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Conversation

rgwood
Copy link
Collaborator

@rgwood rgwood commented Mar 7, 2022

The book intro shows a lot of examples, and they had not been updated since engine-q. I reran the examples on v0.59.1 and updated the intro accordingly.

Notes

  • I intentionally kept things largely the same as before - I ran the obviously-macOS examples on macOS, and the obviously-Linux examples on Linux. And I tweaked the results so the username + machine name are the same.
  • It's a bit weird that virtual memory usage is ~32GB for every process on macOS. Suspect it's a bug related to this and this. It's arguably not ideal to show a bug in the intro docs; if people care about this I could run the examples on another OS?
  • The date now example isn't quite accurate because of this bug. I left a note there to fix up the docs when the bug is fixed.
  • The syntax coloring's a bit off because the entire snippet is interpreted as a bash script. That should probably be changed eventually but it's no worse than before:

image

image

@fdncred
Copy link
Collaborator

fdncred commented Mar 7, 2022

Looks good! Thanks!

@fdncred fdncred merged commit e108fd9 into nushell:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants