Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document query is a plugin. #1446

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Document query is a plugin. #1446

merged 2 commits into from
Jun 15, 2024

Conversation

apraga
Copy link
Contributor

@apraga apraga commented Jun 15, 2024

Fixes #1441 .

@apraga apraga changed the title Document query is a plugin. Fixes #1441 . Document query is a plugin. Jun 15, 2024
make_docs.nu Outdated
@@ -254,7 +254,7 @@ $"($example.description)
$'::: warning(char nl)Dataframe commands were not shipped in the official binaries by default, you have to build it with `--features=dataframe` flag(char nl):::(char nl)(char nl)'
} else { '' }

let plugins = if $command.name in ['from ini', 'from ics', 'from eml', 'from vcf'] {
let plugins = if $command.name in ['from ini', 'from ics', 'from eml', 'from vcf', 'query', 'query xml', 'query json', 'query web'] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
The message below points to nu_plugin_formats. Could we make the message specific to nu_plugin_query as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that ! It should be fixed in the new commit. By the way, I could not generate the documentation using make_docs.nu directly so I'm not sure it compiles.

make_docs.nu Outdated Show resolved Hide resolved
make_docs.nu Outdated Show resolved Hide resolved
make_docs.nu Outdated Show resolved Hide resolved
Copy link
Collaborator

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you make the changes that I suggested then do nu make_docs.nu the script should work.

@apraga
Copy link
Contributor Author

apraga commented Jun 15, 2024

Thanks @fdncred for the follow-up ! Can't believe I introduced a typo... The scripts still fails (and has before my change) with a super-long error message that ends with a issue about sort-by category on nushell 0.94.2.

@fdncred
Copy link
Collaborator

fdncred commented Jun 15, 2024

You may need to use 0.94.3. That's what version I used to test it.

@apraga
Copy link
Contributor Author

apraga commented Jun 15, 2024

Even with 0.94.3, I still have the same very long error messages. I'm not sure this PR is theplace to discuss debug issues but it comes from let commands = ( scope commands | join (command-names) name | sort-by category ).

@fdncred
Copy link
Collaborator

fdncred commented Jun 15, 2024

I've ran it twice without issues.

3 times now
image

@fdncred fdncred merged commit 230767a into nushell:main Jun 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query help page should mention it's a plugin
3 participants