Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to bash-env to cookbook #1434

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Conversation

tesujimath
Copy link
Contributor

Using bash-env is a lot simpler than using the convoluted work-arounds currently described there.

@fdncred
Copy link
Collaborator

fdncred commented Jun 3, 2024

I'm not sure how I feel pushing other tools here in the cookbook. The real intent of the cookbook is to teach people how to use nushell, not how to work-around nushell.

@tesujimath
Copy link
Contributor Author

The problem here is that the cookbook makes it look quite awkward to use Bash environment, but that's not the case with the plugin.

I noticed also on a discussion that people have been wasting time solving this very same problem.

I encourage you to embrace the wider community contributions, so that all will benefit.

(I was careful to describe the plugin as third-party BTW.)

Alternatively, you could simply remove the description of importing Bash environment and integrating with ssh-agent, as those descriptions are no longer best practice, and are in fact misleading IMO.

@fdncred
Copy link
Collaborator

fdncred commented Jun 3, 2024

My comments aren't an indictment on your plugin but more of a comment about our documentation and the support we provide. If it's in our documentation people will ask us to support it, so we need to be careful about which external tools we allow in our documentation since we already have a hard time supporting everything nushell does. This may be able to be addressed by having some warning statement saying that questions regarding your plugin should be addressed in your repo.

Your plugin also uses jq which could be seen as a competitor to nushell in some respects. I wonder if it could be created without external dependencies like this.

One thing that I do love about your plugin is that it's written in a scripting language other than nushell. I'm not sure if you've seen it but devyn recently created a plugin written in nushell script. I'd personally love to see plugins written in several languages.

@tesujimath
Copy link
Contributor Author

Totally understand your concern about implying it is supported by the core Nushell team. Have pushed up a very clear statement about that.

Regarding the use of jq, I don't think there's a reasonable alternative. Trying to parse JSON with raw bash would be error prone and quite unworkable I think. Using Nu itself would be really heavyweight for something for which jq is absolutely the right tool. In Nu land, jq is obsolete. But this plugin doesn't run in Nu land, it runs outside.

The very nature of the bash-env plugin is that it has to be written in Bash. Everything else follows on from that.

@fdncred fdncred merged commit 3a6deb1 into nushell:main Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants