Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframes chapter update to reflect the latest changes #1414

Merged
merged 34 commits into from
May 28, 2024

Conversation

maxim-uvarov
Copy link
Contributor

wip

@maxim-uvarov
Copy link
Contributor Author

  • updated benchmarks
  • removed the part with loading benchmarks and left only group-by section
  • updated reference texts accordingly
  • renamed variables
  • updated outputs of all the code chunks (and checked that they are executable)

I'm in the process of updating the markdown table with commands at the end of the chapter, but I will submit results a separate commit some other day.

There are still might be some typos, or incorrect explanations. I would be grateful if anybody could check them too.

@maxim-uvarov maxim-uvarov marked this pull request as ready for review May 28, 2024 14:30
@maxim-uvarov
Copy link
Contributor Author

maxim-uvarov commented May 28, 2024

numd run dataframes.md --prepend-intermid "$env.config.footer_mode = 'never';
$env.config.table.header_on_separator = false; $env.config.table.mode = 'default'; $env.config.table.trim.methodology = wrapping; $env.config.table.abbreviated_row_count = 10000" --intermid-script `polars-eager.nu` --width 120 --echo --no-info | ansi strip | str replace -ar ' \d?\d?\d(ns|µs)' '' | save dataframes.md -f

@fdncred
Copy link
Collaborator

fdncred commented May 28, 2024

looking good. ready to land this?

@devyn
Copy link
Contributor

devyn commented May 28, 2024

0.94.0 is out now, but I'll hold off until @maxim-uvarov says this is good to go

@maxim-uvarov
Copy link
Contributor Author

@devyn yes, please, merge it

@fdncred fdncred merged commit b10016d into nushell:main May 28, 2024
2 checks passed
@fdncred
Copy link
Collaborator

fdncred commented May 28, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants