Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ja documents to align with cfc7b0d #1186

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

YukiOnodera
Copy link
Contributor

@YukiOnodera YukiOnodera commented Dec 26, 2023

I have updated and translated the following files.

  • sidebar topics
  • README.md
  • getting_started.md

Source commit id is cfc7b0d.

@YukiOnodera YukiOnodera changed the title Updated ja translation Updated ja documents align with cfc7b0d Dec 26, 2023
@YukiOnodera YukiOnodera changed the title Updated ja documents align with cfc7b0d Updated ja documents to align with cfc7b0d Dec 26, 2023
@hustcer
Copy link
Collaborator

hustcer commented Jan 3, 2024

There are some conflicts after your previous PR got merged: #1179

@YukiOnodera
Copy link
Contributor Author

@hustcer Thank you for your comment.
I resolved conflicts to align with cfc7b0d.
Will you please review it again?

@hustcer
Copy link
Collaborator

hustcer commented Jan 11, 2024

Looks good to me, let's merge it. Thanks

@hustcer hustcer merged commit 6e3d4ed into nushell:main Jan 11, 2024
2 checks passed
@YukiOnodera YukiOnodera deleted the feature/add-ja-transcription branch January 11, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants