Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the SSH agent snippet #1169

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Dec 11, 2023

i did a logout on my machine and noticed the SSH agent i took from the book stopped working 😮
i fixed it and thought it would be great to update the book 😇

description

@fdncred
Copy link
Collaborator

fdncred commented Feb 3, 2024

@amtoine i'm assuming you forgot about this PR. is it ready to land?

@amtoine
Copy link
Member Author

amtoine commented Feb 6, 2024

@fdncred
aah yeah, it looks like i forgot 😮

as it looks exactly the same as the one i use everyday, i guess it's ready to land 😉

@fdncred fdncred merged commit 772b435 into nushell:main Feb 6, 2024
2 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Feb 6, 2024

lol. Thanks!

^ssh-agent -c
do --env {
let ssh_agent_file = (
$nu.temp-path | path join $"ssh-agent-($env.USER? | default $env.USERNAME).nuon"
Copy link
Contributor

@wanesty wanesty May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amtoine i'm assuming you wrote $env.USER? | default $env.USERNAME for cross-platform compatibility but $env.USERNAME doesn't exists on linux, so i think both $env user variables would need a ? and thus maybe a check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants