Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This tip document of environment variables seem broken and unclear. #1024

Closed
otakutyrant opened this issue Aug 21, 2023 · 1 comment · Fixed by #1423
Closed

This tip document of environment variables seem broken and unclear. #1024

otakutyrant opened this issue Aug 21, 2023 · 1 comment · Fixed by #1423
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@otakutyrant
Copy link

Describe the bug

https://www.nushell.sh/book/modules.html#environment-variables

It miss a open bracket, and I still cannot get what the tip says.

How to reproduce

Skipped.

Expected behavior

Skipped.

Screenshots

2023-08-21-174133_1205x683_scrot

Configuration

Skipped.

Additional context

No response
@amtoine amtoine transferred this issue from nushell/nushell Aug 25, 2023
@amtoine amtoine added documentation Improvements or additions to documentation good first issue Good for newcomers labels Aug 25, 2023
@fdncred
Copy link
Collaborator

fdncred commented Aug 25, 2023

Should be easy to fix. This is the file https://github.com/nushell/nushell.github.io/blob/main/book/modules.md#environment-variables that would need to be updated.

Kissaki added a commit to Kissaki/nushell.github.io that referenced this issue May 29, 2024
@Kissaki
Fix module env usage tip
c9d6a40 
Fixes nushell#1024

Use a more concise example, similar to the previous one.

Add usage example with proof.
@Kissaki Kissaki mentioned this issue May 29, 2024
Merged
fdncred pushed a commit that referenced this issue Jun 6, 2024
@Kissaki
Fix module env usage tip (#1423)
934d420 
* Fix module env usage tip

Fixes #1024

Use a more concise example, similar to the previous one.

Add usage example with proof.

* Improve wording

The 'also' serves no purpose. It's unclear what [previous content] it refers to.
maxim-uvarov pushed a commit to maxim-uvarov/nushell.github.io that referenced this issue Jun 7, 2024
@Kissaki @maxim-uvarov
Fix module env usage tip (nushell#1423)
adcb1d3 
* Fix module env usage tip

Fixes nushell#1024

Use a more concise example, similar to the previous one.

Add usage example with proof.

* Improve wording

The 'also' serves no purpose. It's unclear what [previous content] it refers to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix module env usage tip Kissaki/nushell.github.io
3 participants
@fdncred @amtoine @otakutyrant