Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs refer to non-existing config option 'table_mode' #1007

Closed
emil-e opened this issue Aug 17, 2023 · 2 comments · Fixed by #1008
Closed

Docs refer to non-existing config option 'table_mode' #1007

emil-e opened this issue Aug 17, 2023 · 2 comments · Fixed by #1008

Comments

@emil-e
Copy link

emil-e commented Aug 17, 2023

Describe the bug

These docs:
https://www.nushell.sh/book/coloring_and_theming.html#table-borders

Refer to table_mode but these days it seems to be table.mode.

How to reproduce

Read the docs, try doing what it says.

Expected behavior

Docs to match released code.

Screenshots

No response

Configuration

Not relevant

Additional context

No response
@hustcer hustcer transferred this issue from nushell/nushell Aug 17, 2023
@hustcer
Copy link
Collaborator

hustcer commented Aug 17, 2023 •
edited
Loading

@emil-e Thanks, the issue has been transferred to Nushell docs' repo, and PRs are welcomed

@fdncred
Copy link
Collaborator

fdncred commented Aug 17, 2023

You're right, it's now $env.config.table.mode. We rearranged some things since I wrote that page. It probably deserves a good cleanup.

hustcer added a commit to hustcer/nushell.github.io that referenced this issue Aug 19, 2023
@hustcer
Update table mode config doc, fix nushell#1007
72b1986
@hustcer hustcer mentioned this issue Aug 19, 2023
Merged
hustcer added a commit that referenced this issue Aug 19, 2023
@hustcer
Update table mode config doc, fix #1007 (#1008)
e596774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update table mode config doc, fix #1007 hustcer/nushell.github.io
3 participants
@fdncred @hustcer @emil-e