Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the last path token as destination for install #35

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Oct 22, 2023

related to

Description

when trying to make the themes of the nu_scripts a module that can be installed as part of the nu-scripts package in nushell/nu_scripts#648, there is a big issue: all the files in the themes directory are installed, this includes the themes but also a README, script, and 55Mb of screenshots 🤔

in this PR i try to mitigate that issue with a simple change 😋

instead of installing the themes from nu-themes/ with ./nu-themes/ in $.modules in package.nuon

#┬────────name─────────┬type
0│nu-themes/README.md  │file
1│nu-themes/make.nu    │file
2│nu-themes/screenshots│dir
3│nu-themes/themes     │dir
─┴─────────────────────┴────

which will install the screenshots, this PR allows to install only the nu-themes/ directory in a themes/ directory, i.e. swap the names of the two directories

#┬───────name───────┬type
0│themes/README.md  │file
1│themes/make.nu    │file
2│themes/nu-themes  │dir
3│themes/screenshots│dir
─┴──────────────────┴────

and then specifying $.modules as being [./themes/nu-themes]

the only change is that the destination for the package is computed as the last path token from $.modules, here nu-themes 👌

@amtoine amtoine requested a review from kubouch October 22, 2023 11:24
@kubouch
Copy link
Contributor

kubouch commented Oct 22, 2023

Thanks, yeah, this makes more sense.

@kubouch kubouch merged commit 273502f into nushell:main Oct 22, 2023
3 checks passed
@amtoine amtoine deleted the fix-nu_scripts-648 branch October 23, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants