use the last path token as destination for install #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
Description
when trying to make the themes of the
nu_scripts
a module that can be installed as part of thenu-scripts
package in nushell/nu_scripts#648, there is a big issue: all the files in the themes directory are installed, this includes the themes but also a README, script, and 55Mb of screenshots 🤔in this PR i try to mitigate that issue with a simple change 😋
instead of installing the themes from
nu-themes/
with./nu-themes/
in$.modules
inpackage.nuon
which will install the screenshots, this PR allows to install only the
nu-themes/
directory in athemes/
directory, i.e. swap the names of the two directoriesand then specifying
$.modules
as being[./themes/nu-themes]
❗the only change is that the destination for the package is computed as the last path token from
$.modules
, herenu-themes
👌