SPEC: add some thoughts about a config file and sensible (?) defaults #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdncred
reviewed
Mar 23, 2023
|
|
||
| - :seven: remove trailing whitespaces | ||
|
|
||
| - :eight: single quotes for single characters and double quotes for strings => that behaviour might change with string interpolation and paths. |
There was a problem hiding this comment.
if you're on windows we cannot use double quotes generally for all strings. it will fail on double quoted paths because nushell sees them as escapes.
There was a problem hiding this comment.
so double quotes except for paths?
i'm really not familiar with these windows details about string 😋
There was a problem hiding this comment.
Maybe we could have some warning section around this that warns the users not to use double quotes with windows paths. They should use single quotes or backtick quotes.
There was a problem hiding this comment.
i can add that for sure 👌
There was a problem hiding this comment.
i've added it in b3c19ab 👍
|
Good enough for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i simply add to the specification what i was talking about the in #nufmt thread in the discord server 👍
please tell me if there's anything that could be corrected or improved 😌