🐛 fix --stdin CLI option
#57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtoine
reviewed
Dec 27, 2023
|
Thank you @amtoine ! With your help I could solve the issue 😄 |
amtoine
reviewed
Dec 29, 2023
There was a problem hiding this comment.
the changes look ok to me, but i'm not sure they address the original issue 🤔
i'm running the following, on top of the PR branch and after a cargo clean:
cargo build --releaseto create./target/release/nufmtfoo out> foo.txtto create a dummy file
and then
./target/release/nufmt --stdin (open foo.txt)still works as beforeopen foo.txt | ./target/release/nufmtgives an erroropen foo.txt | ./target/release/nufmt --stdinalso gives an error
i expected
1.to not work anymore2.to give an error as it did3.to work as 1. does
|
Hello! I break the API and forgot to tell you 😆 . Thank you for listing every case. |
Merged
|
superseded by #61 |
fdncred
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Description of changes `--stdin` flag read a command line argument, not stdin. Now it reads from stdin. Not sure if my code would compile on windows, but I don't have a windows computer to test it. I'm aware that #57 tries to solve this as well, but it seems stagnant and won't pass CI. ## Relevant Issues #56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
WIP
Relevant Issues
#56