Revert "Check Nix flake workflow (#46)" #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5fd22da.
|
This makes sure the flake is functional and doesn't error when someone wants to enter the devshell or build nufmt with nix. |
|
we'll decide the fate of that PR from #52 😉 |
|
#53 Happens anyway because the flake syntax is valid but the package itself built for macos needs Iokit to build. |
|
So if we dont merge #52 then I will write a check that runs on macos to test builds there as well. |
|
#46 has been sorted out, thanks @IogaMaster for the explaining 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
cc/ @IogaMaster
Description of changes
this PR reverts #46.
without any justification for this, i'd rather revert the changes 😋