Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Flake #41

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Basic Flake #41

merged 2 commits into from
Sep 27, 2023

Conversation

IogaMaster
Copy link
Contributor

Here is a basic flake for the project.

Features:

  • Multi architecture builds (aarch64, x86_64, risc, etc)
  • Reproducible development environments. Run nix develop and you have the locked version of Rust and rust-analyzer
  • Reproducable builds.

Let me know any other changes that need to be made

@IogaMaster
Copy link
Contributor Author

Do i need to fix the format issue, the pr doesn't contain rust code.

@fdncred
Copy link
Collaborator

fdncred commented Sep 27, 2023

weird that we'd have a fmt problem here where there's no rust code. maybe we should have a separate pr to fix the fmt issue since it's unrelated to this pr. if something crazy happened and we had to revert this PR, we probably wouldn't want to revert the fmt change.

@IogaMaster
Copy link
Contributor Author

I'll see about fixing that in a separate pr

@IogaMaster
Copy link
Contributor Author

Also would we want direnv for automatic runs of nix develop when applicable.
https://github.com/direnv/direnv

@IogaMaster
Copy link
Contributor Author

#43

@fdncred
Copy link
Collaborator

fdncred commented Sep 27, 2023

Also would we want direnv for automatic runs of nix develop when applicable. https://github.com/direnv/direnv

I'm agnostic on direnv. I know some people use it and love it. Others don't. One key that we always have to keep in mind is that nufmt, and the nushell family of programs, aren't just Linux or Mac programs. We need to continue to try to be as cross-platform as possible and support Windows.

@IogaMaster
Copy link
Contributor Author

IogaMaster commented Sep 27, 2023

Nix is not on windows but it would be just for mac and linux devs same as the direnv thing as it would use nix-direnv
Windows dev's would work the same way they would normally.

I like to have Nix be optional to developing a project, just a nice addition.

@IogaMaster
Copy link
Contributor Author

I want to remove the merge commit first

@fdncred
Copy link
Collaborator

fdncred commented Sep 27, 2023

I like to have Nix be optional to developing a project, just a nice addition.

Right. I'm not objecting to this as an optional thing at all. Just reminding onlookers that we're cross-platform, so every PR will be seen in that light.

@fdncred
Copy link
Collaborator

fdncred commented Sep 27, 2023

Thanks

@fdncred fdncred merged commit 78db005 into nushell:main Sep 27, 2023
4 checks passed
@IogaMaster IogaMaster deleted the flake branch September 27, 2023 18:34
amtoine added a commit to amtoine/nufmt that referenced this pull request Sep 28, 2023
@siph siph mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants