馃摑 rework the specification docs #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdncred
reviewed
Mar 20, 2023
|
|
||
| This is the list of the supported commands and their idiomatic formatting. Indentation will be covered by the `--indent` flag but for these examples, 4 spaces will be used. | ||
|
|
There was a problem hiding this comment.
maybe add my original part back here instead of deleting the supported commands.
fdncred
reviewed
Mar 21, 2023
|
|
||
| This specification serves as a starting point to document how `nufmt` should work when formatting nushell scripts. It's meant to be very basic at this point, gradually covering more of the language features. | ||
| > rust has rsfmt |
There was a problem hiding this comment.
Suggested change
| > rust has rsfmt | |
| > rust has fmt |
|
I took most of your points and added them into the specification. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I did some work on the specification.
I took a chance to add some flavor and separate the specification itself from the app need. So first is what standard should comply, and after that are what options we would like to have on the
nufmt. Is that ok?PD: I change the indentation of 2 spaces to 4 spaces 馃槅