Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the "formatting identity" comment a bit clearer #39

Merged
merged 1 commit into from
Jun 27, 2023
Merged

make the "formatting identity" comment a bit clearer #39

merged 1 commit into from
Jun 27, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jun 26, 2023

should close #37 by making the debug message clearer

File is already formatted correctly.

instead of

File is formatted correctly.

cc/ @AucaCoyan

AucaCoyan
AucaCoyan approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@AucaCoyan AucaCoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@amtoine amtoine merged commit 5ed97a6 into nushell:main Jun 27, 2023
4 checks passed
@amtoine amtoine deleted the fix/formatting-identity-comment branch June 27, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AucaCoyan AucaCoyan AucaCoyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strange condition and debug statement
2 participants
@amtoine @AucaCoyan