Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and polish the source code of the library #29

Merged
merged 15 commits into from
Jun 16, 2023
Merged

refactor and polish the source code of the library #29

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cb90243
rename the library into `nu_formatter`
amtoine Jun 15, 2023
d172e01
link the `main.rs` doc to the README
amtoine Jun 15, 2023
e662352
run *Clippy* on `--all-targets`
amtoine Jun 15, 2023
e8dd93a
use log instead of print except with formatting a string
amtoine Jun 15, 2023
5b5f117
fix the cli.files hack
amtoine Jun 15, 2023
d4bb23a
implement the "windows newline" trick
amtoine Jun 16, 2023
eae1b46
use a more expressive exit_code enum
amtoine Jun 15, 2023
0dbb734
simplify the benchmark
amtoine Jun 15, 2023
880ecc1
rename execute_string and execute_format in main
amtoine Jun 15, 2023
98324ec
remove useless comments and document
amtoine Jun 15, 2023
c183e04
make *Clippy* happy except for missing doc
amtoine Jun 16, 2023
13b91dc
remove the Clippy errors for missing documentation
amtoine Jun 16, 2023
3433524
do not add a `\r` when on windows, always a single `\n`
amtoine Jun 16, 2023
fd032a0
fix the visibility of `nu_formatter` items
amtoine Jun 16, 2023
a43cc16
be explicit about `-D warnings` in the CI
amtoine Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run *Clippy* on --all-targets 
otherwise, warnings from the documentation and the benchmarks
for instance are not seen when running the CI or `toolkit clippy` :o

we also make sure we use the same clippy command in the toolkit.
  • Loading branch information
@amtoine
amtoine committed Jun 16, 2023
commit e66235245c8c2aaba73e0077439c7f70deadabca
2 changes: 2 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ jobs:
- name: Clippy
run: |
cargo clippy \
--all-targets \
--no-deps \
--workspace \
-- \
-D rustdoc::broken_intra_doc_links \
-W missing_docs \
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ jobs:
- name: Clippy
run: |
cargo clippy \
--all-targets \
--no-deps \
--workspace \
-- \
-D rustdoc::broken_intra_doc_links \
-W missing_docs \
Expand Down
3 changes: 3 additions & 0 deletions toolkit.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,11 @@ export def clippy [

try {(
cargo clippy
--all-targets
--no-deps
--workspace
--
-D warnings
-D rustdoc::broken_intra_doc_links
-W missing_docs
-W clippy::missing_docs_in_private_items
Expand Down