Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Add docs for contributing and private items #26

Merged
merged 9 commits into from
Jun 14, 2023
Merged

📝 Add docs for contributing and private items #26

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b97279
:memo: Add docs for contributing and private items
AucaCoyan Jun 11, 2023
87754b5
:pencil2: fix in `CONTRIBUTING.md`
AucaCoyan Jun 11, 2023
6c57961
:pencil2: fix the title
AucaCoyan Jun 11, 2023
e6a2e00
add a link to the #nufmt channel in the Discord server
amtoine Jun 12, 2023
13ae3b0
fix the Discord links with the new #nufmt channel
amtoine Jun 13, 2023
c1f18dd
:pencil2: resolved changes asked in the PR
AucaCoyan Jun 13, 2023
9123aa3
revert the Discord link change from c1f18dd
amtoine Jun 14, 2023
8b11060
add *Clippy* options to the CI
amtoine Jun 14, 2023
6dee590
refactor the toolkit
amtoine Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert the Discord link change from c1f18dd 
actually there are link *variables* at the bottom of the document
which makes it easier to read i think and the link to the `#nufmt`
channel is wrong:
- https://discord.com/channels/601130461678272522/1117921521520873623 is
  the new `#nufmt` channel
- https://discord.com/channels/601130461678272522/1087437882396004442
  was the link of the closed `#nufmt` threads under the `#general`
  channel
  • Loading branch information
@amtoine
amtoine committed Jun 14, 2023
commit 9123aa3527246d38a46897521c75b0323be29aa0
2 changes: 1 addition & 1 deletion docs/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Salutations! Thanks for coming by and the interest into this project!
We would like to order the contributions like this:

- Before you start hacking, it is important to **ask first** if your idea or bugfix is in order.
Create an issue or come and say hi in the [`#nufmt` channel](https://discord.com/channels/601130461678272522/1087437882396004442) by joining [the discord](https://discord.gg/NtAbbGn).
Create an issue or come and say hi in the [`#nufmt` channel][nufmt discord channel] by joining [the discord][Nushell discord].
We don't bite!.

It would be sad that you do the effort to clone the project, successfully make the PR, but it wasn't in our plans or there is another PR that is currently adressing that issue.
Expand Down