Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the tests #22

Merged
merged 4 commits into from
Jun 9, 2023
Merged

refactor the tests #22

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bf21b7
move the comment of the ignored tests to the *ignore* reason
amtoine Jun 9, 2023
b8d2771
put "expected" after "actual" for consistency
amtoine Jun 9, 2023
a03a4ac
remove the whitespace from the `handle_escaped_strings` test
amtoine Jun 9, 2023
864717f
make the "expected" explicit in all tests
amtoine Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
move the comment of the ignored tests to the *ignore* reason
  • Loading branch information
@amtoine
amtoine committed Jun 9, 2023
commit 5bf21b7a7adecdff2dd883dfa57bf30cdcd9a21f
5 changes: 1 addition & 4 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,8 @@ mod test {
assert_eq!(expected, format_string(&nu, &Config::default()));
}

// comments aren't a part of Spans,
// we need another way of reading a skipping comments
// otherwise the nufmt directly remove them.
#[test]
#[ignore]
#[ignore = "comments aren't a part of Spans,"]
fn ignore_comments() {
let nu = String::from("# this is a comment");
let expected = String::from("# this is a comment");
Expand Down