Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make nufmt keep the comments #18

Merged
merged 4 commits into from
Jun 9, 2023
Merged

make nufmt keep the comments #18

merged 4 commits into from
Jun 9, 2023

Conversation

AucaCoyan
Copy link
Contributor

This tacke the issue #17

@AucaCoyan AucaCoyan mentioned this pull request Jun 6, 2023
22 tasks
@amtoine amtoine linked an issue Jun 6, 2023 that may be closed by this pull request
I need to fix having multiple comments, the split works with token.span.start that may by larger than the content length. Afterwards, I need to deal with returning the code and the comment, indicating which is which and how to re-assemble once it is formatted
@AucaCoyan AucaCoyan changed the title 🚧 working on keeping comments make nufmt keep the comments Jun 9, 2023
@AucaCoyan AucaCoyan marked this pull request as ready for review June 9, 2023 18:16
@fdncred fdncred merged commit 113a2d2 into nushell:main Jun 9, 2023
4 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Jun 9, 2023

Thanks!

@AucaCoyan
Copy link
Contributor Author

I ended using your method fdncred, because it was easier. I tried doing a separate module, but it was too complex to manage parts with code to format and parts with comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the formatter keep comments
2 participants