Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clippy happy and add a github workflow #12

Merged
merged 4 commits into from
Jun 1, 2023
Merged

make clippy happy and add a github workflow #12

merged 4 commits into from
Jun 1, 2023

Conversation

AucaCoyan
Copy link
Contributor

Hi! It's me again.
I made clippy stop complaining and setup a github workflow, so we can have alerts when commits are not compliant.

@fdncred
Copy link
Collaborator

fdncred commented Jun 1, 2023

Thanks!

@fdncred fdncred merged commit 205315b into nushell:main Jun 1, 2023
@AucaCoyan AucaCoyan mentioned this pull request Jun 1, 2023
22 tasks
@amtoine
Copy link
Member

amtoine commented Jun 2, 2023

looking good, looking good 😊

@AucaCoyan now some tests? 😏

@AucaCoyan
Copy link
Contributor Author

AucaCoyan commented Jun 2, 2023

I would like to!
First I need to refactor the code to be able to format a String or stdin.
Then all the examples go down the toilet and we write tests for everything.
It's also a nice moment to add tests in CI

@amtoine
Copy link
Member

amtoine commented Jun 3, 2023

I would like to! First I need to refactor the code to be able to format a String or stdin. Then all the examples go down the toilet and we write tests for everything. It's also a nice moment to add tests in CI

sounds great to me 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants